Remove async from instantiating LogTabViewModel

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
lensapp · Feb 17, 2023 · 96ce8bb · 96ce8bb
1 parent 902bcd7
commit 96ce8bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/packages/core/src/renderer/components/dock/logs/logs-view-model.injectable.ts b/packages/core/src/renderer/components/dock/logs/logs-view-model.injectable.ts
@@ -28,7 +28,7 @@ export interface InstantiateArgs {
 const logsViewModelInjectable = getInjectable({
   id: "logs-view-model",
 
-  instantiate: async (di, tabId: TabId) => new LogTabViewModel(tabId, {
+  instantiate: (di, tabId) => new LogTabViewModel(tabId, {
     getLogs: di.inject(getLogsInjectable),
     getLogsWithoutTimestamps: di.inject(getLogsWithoutTimestampsInjectable),
     getTimestampSplitLogs: di.inject(getTimestampSplitLogsInjectable),

diff --git a/packages/core/src/renderer/components/dock/logs/view.tsx b/packages/core/src/renderer/components/dock/logs/view.tsx
@@ -20,7 +20,6 @@ import type { SubscribeStores } from "../../../kube-watch-api/kube-watch-api";
 import subscribeStoresInjectable from "../../../kube-watch-api/subscribe-stores.injectable";
 import type { PodStore } from "../../+workloads-pods/store";
 import podStoreInjectable from "../../+workloads-pods/store.injectable";
-import { Spinner } from "../../spinner";
 
 export interface LogsDockTabProps {
   className?: string;
@@ -100,11 +99,9 @@ const NonInjectedLogsDockTab = observer(({
 
 
 export const LogsDockTab = withInjectables<Dependencies, LogsDockTabProps>(NonInjectedLogsDockTab, {
-  getPlaceholder: () => <Spinner center data-testid="pod-logs-tab-content-spinner" />,
-
-  getProps: async (di, props) => ({
+  getProps: (di, props) => ({
     ...props,
-    model: await di.inject(logsViewModelInjectable, props.tab.id),
+    model: di.inject(logsViewModelInjectable, props.tab.id),
     subscribeStores: di.inject(subscribeStoresInjectable),
     podStore: di.inject(podStoreInjectable),
   }),