Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move navigation/menus registration from PageRegistration to own registry #1258

Closed
jakolehm opened this issue Nov 6, 2020 · 0 comments · Fixed by #1334
Closed

Move navigation/menus registration from PageRegistration to own registry #1258

jakolehm opened this issue Nov 6, 2020 · 0 comments · Fixed by #1334
Assignees
@ixrock
Labels
area/extension Something to related to the extension api enhancement New feature or request
Milestone
4.0.0

Comments

@jakolehm
Copy link
Contributor

jakolehm commented Nov 6, 2020

Now it's embedded into a global page registration. Would be clearer if a menu item would be a separated api.
@jakolehm jakolehm added enhancement New feature or request area/extension Something to related to the extension api labels Nov 6, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Nov 6, 2020
@ixrock ixrock changed the title Separate menu item registration from global page registration Move navigation/menus registration from PageRegistration to own registry Nov 6, 2020
@ixrock ixrock self-assigned this Nov 9, 2020
ixrock added a commit that referenced this issue Nov 10, 2020
@ixrock
PageRegistration refactoring #1258 -- part 1
9ec91c0 
Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock mentioned this issue Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixrock ixrock

Labels
area/extension Something to related to the extension api enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

PageRegistration & BaseRegistry refactoring lensapp/lens
2 participants
@jakolehm @ixrock