Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.3.0 cannot build binary with extensions #6819

Closed
ogarcia opened this issue Dec 22, 2022 · 9 comments
Closed

v6.3.0 cannot build binary with extensions #6819

ogarcia opened this issue Dec 22, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@ogarcia
Copy link

ogarcia commented Dec 22, 2022

I'm Arch Linux AUR package mantainer.

Since upgrading to version 6.3.0 I am not able to build the open-lens binary with the extensions.

I used to build the extensions with the make build-extensions command as follows:

make node_modules
yarn download:binaries
yarn run build:tray-icons
make build-extensions
yarn dist:dir

But in this latest update the command make build-extensions has been removed.

I have tried to do the following:

make node_modules
yarn download:binaries
yarn run build:tray-icons
make build-npm
yarn dist:dir

This leaves me with the binary in the dist/linux-unpacked directory, but does not include the extensions.

@ogarcia ogarcia added the bug Something isn't working label Dec 22, 2022
@msa0311
Copy link
Contributor

msa0311 commented Dec 23, 2022

The in-tree extensions have been removed from with 6.3.0, see the following issues / PRs that explain the background:

@msa0311 msa0311 closed this as completed Dec 23, 2022
@ogarcia
Copy link
Author

ogarcia commented Dec 23, 2022

@msa0311 Yes, I know, I saw those changes. But supposedly (if I understand correctly) with #6715 the extensions like node-menu and pod-menu are already included in the package.

What happens to me is that since this change I don't see the buttons to open a shell in the pod or see its logs, something that before appeared thanks to the extensions.

@jakolehm
Copy link
Contributor

#6715 was the first bigger change related to improvements but it still had one major drawback that was cyclic dependency within thelensapp/lens repository (in-tree extensions pointing to @k8slens/extensions and lensapp/lens package.json pointing to in-tree extensions).

@ogarcia
Copy link
Author

ogarcia commented Dec 23, 2022

That is, if I understand correctly, with version 6.3.0 the options to open a shell in the pods or to see the logs have been lost (among others).

@msa0311
Copy link
Contributor

msa0311 commented Dec 23, 2022

It's no longer part of this repository. The functionality is still available in the Lens Desktop distribution that can be downloaded from here: https://k8slens.dev

@ogarcia
Copy link
Author

ogarcia commented Dec 23, 2022

Ok. It is unfortunate that this decision was made. Surely the number of users will drop and possibly we will stop updating the package in Arch.

In any case, thank you very much for your help.

@lingwooc
Copy link

I'd have a lot more respect for you if you admitted you'd taken the decision to take core functionality closed source for commerical reasons.

@szinn
Copy link

szinn commented Dec 23, 2022

That's extremely unfortunate. It essentially makes the tool useless. You can see something isn't running, but have to now resort to a command-line or another tool to understand why.

@jkroepke
Copy link
Contributor

It's no longer part of this repository. The functionality is still available in the Lens Desktop distribution that can be downloaded from here: k8slens.dev

Where is the source code repository for the Lens Desktop distribution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants