Include bundled extensions in package.json #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jakolehm
requested review from
Iku-turso and
ixrock
and removed request for
a team
Nokel81
previously approved these changes
Dec 12, 2022
ixrock
previously approved these changes
Dec 12, 2022
package.json
Outdated
Comment on lines
290
to
294
| "xterm-link-provider": "^1.3.1", | ||
| "kube-object-event-status": "file:./extensions/kube-object-event-status", | ||
| "metrics-cluster-feature": "file:./extensions/metrics-cluster-feature", | ||
| "node-menu": "file:./extensions/node-menu", | ||
| "pod-menu": "file:./extensions/pod-menu" |
There was a problem hiding this comment.
I'm wondering why those are still extensions if needs to be always bundled?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ixrock
approved these changes
Dec 13, 2022
Merged
This was referenced Dec 23, 2022
alebcay
added a commit
to alebcay/lens
that referenced
this pull request
Dec 28, 2022
This reverts commit 012944d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6749