Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extension to specify storeName #7052

Closed
panuhorsmalahti opened this issue Jan 30, 2023 · 2 comments · Fixed by #7107 or #7188
Closed

Allow extension to specify storeName #7052

panuhorsmalahti opened this issue Jan 30, 2023 · 2 comments · Fixed by #7107 or #7188
Assignees
Labels
area/extension Something to related to the extension api blocker enhancement New feature or request
Milestone

Comments

@panuhorsmalahti
Copy link
Contributor

If extension's package.json specifies storeName property which is set to a truthy value, use it for persisting data (e.g. extension stores and extension data) instead of the extension name.

This allows extension to be renamed without losing data.

@panuhorsmalahti panuhorsmalahti added enhancement New feature or request area/extension Something to related to the extension api labels Jan 30, 2023
@panuhorsmalahti panuhorsmalahti added this to the 6.4.0 milestone Jan 30, 2023
@panuhorsmalahti
Copy link
Contributor Author

panuhorsmalahti commented Jan 30, 2023

Note that extension can set the storeName also in an injectable (using bundledExtensionInjectionToken).

@apialaviiva apialaviiva self-assigned this Jan 30, 2023
@Nokel81
Copy link
Collaborator

Nokel81 commented Jan 30, 2023

It is the opinion of the core team that using a field within the package.json would be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension Something to related to the extension api blocker enhancement New feature or request
Projects
None yet
4 participants