Enable extension to specify storeName for persisting data #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
panuhorsmalahti
added
the
area/extension
Signed-off-by: Antti Lustila <antti.lustila@luotocompany.fi>
apialaviiva
requested review from
jansav and
jim-docker
and removed request for
a team
jweak
reviewed
Feb 15, 2023
packages/core/src/extensions/__tests__/configurable-directories.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Antti Lustila <antti.lustila@luotocompany.fi>
ixrock
approved these changes
Feb 15, 2023
| @@ -80,6 +87,11 @@ export class LensExtension< | |||
| return this.manifest.description; | |||
| } | |||
|
|
|||
| // Name of extension for persisting data | |||
| get storeName() { | |||
| return this.manifest.storeName || this.name; | |||
There was a problem hiding this comment.
nit:
Suggested change
| return this.manifest.storeName || this.name; | |
| return this.manifest.storeName ?? this.name; |
There was a problem hiding this comment.
I don't think we want this. If storeName is set as "", we want to fall back to name.
| const getHashInjectable = getInjectable({ | ||
| id: "get-hash", | ||
|
|
||
| instantiate: () => (text: string) => SHA256(text).toString(), |
There was a problem hiding this comment.
Should we add causesSideEffects: true since used external imported package?
There was a problem hiding this comment.
In don't think that is necessary because a hash should be stable given its input
jweak
approved these changes
Feb 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7052
storeName, it is used for specifying extension data locations instead of extension name