Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to show previous terminated container logs #1074

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Ability to show previous terminated container logs #1074

merged 2 commits into from
Oct 12, 2020

Conversation

aleksfront
Copy link
Contributor

Based on @Nox-404 PR (#746) which adds control to show logs for previous containers. Emulates kubectl get logs --previous behavior.

previous container logs

Fixes #497
Fixes #602

@aleksfront
Show previous terminated container logs
9afcf6c 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Fix for parsing error object
80df0da 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront requested a review from a team October 12, 2020 07:14
ixrock
ixrock approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@ixrock ixrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksfront aleksfront merged commit 83b8fa9 into master Oct 12, 2020
@aleksfront aleksfront deleted the container-previous-logs branch October 12, 2020 12:58
@aleksfront aleksfront mentioned this pull request Oct 12, 2020
Closed
@nevalla nevalla added the enhancement New feature or request label Oct 14, 2020
@nevalla nevalla added this to the 3.7.0 milestone Oct 14, 2020
@nevalla nevalla modified the milestones: 3.7.0, 4.0.0 Oct 26, 2020
@jakolehm jakolehm mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixrock ixrock ixrock approved these changes

Assignees
No one assigned
Labels
area/ui enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Dump of previous container logs Support viewing previously failed pod logs
3 participants
@aleksfront @ixrock @nevalla