Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tracker to telemetry extension #1092

Merged
merged 9 commits into from
Oct 19, 2020
Merged

Move tracker to telemetry extension #1092

merged 9 commits into from
Oct 19, 2020

Conversation

jakolehm
Copy link
Contributor

No description provided.

@jakolehm
move tracker to telemetry extension
2a12bb7 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
move tracker to telemetry extension
1fbd106 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added enhancement New feature or request area/extension Something to related to the extension api labels Oct 16, 2020
@jakolehm jakolehm added this to the 3.7.0 milestone Oct 16, 2020
@jakolehm
add tests for EventBus
61d9719 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
ixrock
ixrock reviewed Oct 16, 2020
View reviewed changes
extensions/telemetry/package.json Show resolved Hide resolved
src/common/event-bus.ts Outdated Show resolved Hide resolved
src/extensions/extension-renderer-api.ts Outdated Show resolved Hide resolved
@jakolehm
refactor to use EventEmitter
b909d93 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
fixes
9c00ca2 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm marked this pull request as ready for review October 16, 2020 13:55
@jakolehm jakolehm requested a review from a team October 16, 2020 13:56
@jakolehm
fix eslint
fdd02fd 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
cleanup
f436ff8 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
add app focus/blur events
c814d80 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
add cluster open eventQ
22e8a84 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
nevalla
nevalla approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit c566c85 into extensions-api Oct 19, 2020
@jakolehm jakolehm deleted the move-tracker-to-telemetry-extension branch October 19, 2020 08:56
@nevalla nevalla modified the milestones: 3.7.0, 4.0.0 Oct 26, 2020
@jakolehm jakolehm mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixrock ixrock ixrock left review comments

@nevalla nevalla nevalla approved these changes

Assignees
No one assigned
Labels
area/extension Something to related to the extension api enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakolehm @nevalla @ixrock