-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bundled extension install on Linux/AppImage #1163
Conversation
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -39,7 +47,13 @@ export class ExtensionManager { | |||
|
|||
async load() { | |||
logger.info("[EXTENSION-MANAGER] loading extensions from " + this.extensionPackagesRoot) | |||
await fs.ensureDir(path.join(this.extensionPackagesRoot, "node_modules")) | |||
if (this.inTreeFolderPath !== this.inTreeTargetPath) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when this condition is false? (ie this.inTreeFolderPath === this.inTreeTargetPath
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actually sure (I think it depends on an environment). This is just to safeguard our in-tree extensions (if these match we would remove sources).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other option is to check if this.inTreeFolderPath
is read-only.
Fixes #1162