Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm package missing types #1167

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Fix npm package missing types #1167

merged 1 commit into from
Oct 28, 2020

Conversation

jakolehm
Copy link
Contributor

No description provided.

@jakolehm
force types to npm package
33c9655 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added bug Something isn't working area/extension Something to related to the extension api labels Oct 28, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Oct 28, 2020
@jakolehm jakolehm requested a review from a team October 28, 2020 10:39
@jakolehm jakolehm merged commit 40e228c into master Oct 28, 2020
@jakolehm jakolehm deleted the fix/npm-package-missing-types branch October 28, 2020 10:48
@ixrock
Copy link
Member

ixrock commented Oct 28, 2020

What it does? I guess the real issue was that file api.d.ts just not included while publishing to npm?

@jakolehm jakolehm mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksfront aleksfront aleksfront approved these changes

Assignees
No one assigned
Labels
area/extension Something to related to the extension api bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakolehm @ixrock @aleksfront