Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart deployment #1175

Merged
merged 1 commit into from Nov 5, 2020
Merged

Restart deployment #1175

merged 1 commit into from Nov 5, 2020

Conversation

pashevskii
Copy link
Contributor

@pashevskii pashevskii commented Oct 29, 2020 •
edited by aleksfront

Fixed #603

@pashevskii pashevskii mentioned this pull request Oct 29, 2020
Closed
pashevskii
pashevskii commented Oct 29, 2020
View reviewed changes
src/renderer/api/json-api.ts
@@ -64,7 +64,7 @@ export class JsonApi<D = JsonApiData, P extends JsonApiParams = JsonApiParams> {
}

patch<T = D>(path: string, params?: P, reqInit: RequestInit = {}) {
return this.request<T>(path, params, { ...reqInit, method: "patch" });
return this.request<T>(path, params, { ...reqInit, method: "PATCH" });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI: https://stackoverflow.com/questions/34666680/fetch-patch-request-is-not-allowed
Method PATCH is case sensitive

@jakolehm jakolehm added the enhancement New feature or request label Oct 31, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Oct 31, 2020
@jakolehm jakolehm requested a review from a team October 31, 2020 08:30
@aleksfront aleksfront self-requested a review November 3, 2020 10:24
@pashevskii
Restart deployment
8071fc9 
Signed-off-by: Pavel Ashevskii <pashevskii@mirantis.com>
aleksfront
aleksfront approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksfront aleksfront merged commit d074e04 into lensapp:master Nov 5, 2020
@jakolehm jakolehm mentioned this pull request Nov 10, 2020
Merged
@pashevskii pashevskii deleted the restart-deployment branch December 3, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksfront aleksfront aleksfront approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Restart deployment
3 participants
@pashevskii @aleksfront @jakolehm