Add designated folder for extensions #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/extension
|
This should be merged first #1233 |
|
okay, ping me when that is merged and I will rebase again |
nevalla
reviewed
Nov 6, 2020
ixrock
reviewed
Nov 7, 2020
ixrock
reviewed
Nov 9, 2020
ixrock
reviewed
Nov 13, 2020
ixrock
reviewed
Nov 13, 2020
jakolehm
reviewed
Nov 16, 2020
jakolehm
requested changes
Nov 18, 2020
There was a problem hiding this comment.
filesystemProvisionerStore itself looks good but this PR introduces bunch of other changes that are not related to PR title at all. We should keep PRs small and focused for easier review process. Could you split non-related changes to separate PRs with descriptive title/description why those changes are done.
|
@jakolehm You are correct about the sidecar changes. I have moved them to a separate branch. Are you able to review again? |
jakolehm
reviewed
Nov 18, 2020
Nokel81
force-pushed
the
issue-1179
branch
2 times, most recently
from
b17c9ed
to
bdb66b8
Compare
- add extension mechinism for getting a folder to save files to - add test to make sure that extensions are being loaded - skip extension loading test Signed-off-by: Sebastian Malton <sebastian@malton.name>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method onto
LensExtensionfor getting a unique path to a folder that the extension can use for its own purposes.The folder is based on the extension ID but is not passed in so it cannot be faked. The folder name is salted and then hashed to obfuscate it and the mapping is stored in a lens store which is, by design, not otherwise exposed to extension writers. This is done so that the folder's name is not able to be determined without calling this function.
No security is applied to these folders.
fixes #1179