New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add posibility to add custom helm repository #1368
Conversation
7b1d51a
to
d0ea4f7
Compare
15061c5
to
ba44a56
Compare
ee86afb
to
f147877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is good, just need to add couple of UI fixes.
- Please put
Add Custom Helm Repo
dialog to the right of repo selector. You can do this by moving select and button into parent div element like this:
<h2><Trans>Helm</Trans></h2>
<div className="flex gaps">
<Select id="HelmRepoSelect"
placeholder={<Trans>Repositories</Trans>}
isLoading={this.helmLoading}
isDisabled={this.helmLoading}
options={this.helmOptions}
onChange={this.onRepoSelect}
formatOptionLabel={this.formatHelmOptionLabel}
controlShouldRenderValue={false}
className="box grow"
/>
<Button
primary
label={<Trans>Add Custom Helm Repo</Trans>}
onClick={() => {AddHelmRepoDialog.open()}}
/>
</div>
-
Fix focus/tab states in newly created dialog. When you open it, focus appears not on the first input field, but on the second one. Same happens when you click "More" button - focus activated on last field in list.
-
We can remove first title in dialog so the whole view would be like on the following screenshot
Other visual fixes will be done in separate PRs since whole dialog view should be redefined.
@pashevskii Also, please merge current master changes into your branch and resolve conflict in Check out these commands |
Ok, thank you for your comments, I'll try to fix it today. |
Yes, you can wrap text and plus icon within |
f147877
to
e7c3052
Compare
8ff587a
to
53307dc
Compare
@pashevskii Left 3 more comments, ptal. Otherwise looks good. |
0d028e8
to
612109f
Compare
93da7b0
to
2bb490d
Compare
Signed-off-by: Pavel Ashevskii <pashevskii@mirantis.com>
2bb490d
to
16dcc53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The commit adds the possibility to add a custom helm repository instead of selecting prepared ones
The commit adds new button in preferences - helm section
Warning! Implementation is ugly, need your comments on how to improve it.