Track more events from adding a cluster #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
nevalla
commented
Nov 23, 2020
| @@ -48,6 +49,7 @@ export class AddCluster extends React.Component { | |||
| componentDidMount() { | |||
| clusterStore.setActive(null); | |||
| this.setKubeConfig(userStore.kubeConfigPath); | |||
| appEventBus.emit({ name: "cluster-add", action: "start" }); | |||
There was a problem hiding this comment.
do we already have some syntax recommendation cluster-add vs clusterAdd?
There was a problem hiding this comment.
Not sure about recommendations but I see that we already has some kebab-case notations, for example in src/main/node-shell-session.ts
jakolehm
approved these changes
Nov 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add more telemetry events when user adds a new cluster. These will give us better understanding if some phase is constantly failing and we can improve the flow.
Signed-off-by: Lauri Nevala lauri.nevala@gmail.com