Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change add-cluster to single column layout #1515

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Change add-cluster to single column layout #1515

merged 3 commits into from
Nov 25, 2020

Conversation

jakolehm
Copy link
Contributor

  • more unified look&feel (preferences & cluster settings are already single column)
  • close button (X)
  • longer description/help text moved to docs

image

@jakolehm
change add-cluster to single column layout
1dbacdd 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added enhancement New feature or request area/ui labels Nov 25, 2020
@jakolehm jakolehm requested a review from a team November 25, 2020 11:14
@aleksfront
Copy link
Contributor

Probably needs some padding fine-tuning between the lines. I will push changes in this branch.

@aleksfront aleksfront self-requested a review November 25, 2020 11:25
@jakolehm
cleanup styles
3a9c89a 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
Copy link
Contributor Author

Probably needs some padding fine-tuning between the lines. I will push changes in this branch.

I already did some style cleanup, it should be a bit better.

@aleksfront
Fine-tuning layout/coloring styles
558d641 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Copy link
Contributor

Here is complete look
add clusters light 1
add clusters light 2
add clusters dark 2
add clusters dark 1

@jakolehm
Copy link
Contributor Author

@aleksfront thanks!

@jakolehm jakolehm merged commit 6a92372 into master Nov 25, 2020
@jakolehm jakolehm deleted the add-cluster-single-column-layout branch November 25, 2020 12:54
@jakolehm jakolehm added this to the 4.0.0 milestone Nov 25, 2020
@jakolehm jakolehm mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksfront aleksfront aleksfront approved these changes

Assignees
No one assigned
Labels
area/ui enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakolehm @aleksfront