Remove extension when folder is removed during runtime #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panuhorsmalahti
force-pushed
the
feature/auto-remove-extension
branch
from
de6a1e4
to
ea15cb4
Compare
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
panuhorsmalahti
force-pushed
the
feature/auto-remove-extension
branch
from
ea15cb4
to
3756b8b
Compare
Nokel81
reviewed
Nov 25, 2020
Comment on lines
+71
to
+80
| if (instance) { | ||
| try { | ||
| instance.disable(); | ||
| this.events.emit("remove", instance); | ||
| this.instances.delete(lensExtensionId); | ||
| } catch (error) { | ||
| logger.error(`${logModule}: deactivation extension error`, { lensExtensionId, error }); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
What do you think about the if (!instance) { return; } style instead?
There was a problem hiding this comment.
I don't see that being necessarily better, but fixed
| if (!this.extensions.delete(lensExtensionId)) { | ||
| throw new Error(`Can't remove extension ${lensExtensionId}, doesn't exist.`); | ||
| } | ||
|
|
There was a problem hiding this comment.
New line at the end of a function?
Comment on lines
+11483
to
+11487
| prettier@^2.2.0: | ||
| version "2.2.0" | ||
| resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.2.0.tgz#8a03c7777883b29b37fb2c4348c66a78e980418b" | ||
| integrity sha512-yYerpkvseM4iKD/BXLYUkQV5aKt4tQPqaGW6EsZjzyu0r7sVZZNPJW4Y8MyKmicp6t42XUPcBVA+H6sB3gqndw== | ||
|
|
There was a problem hiding this comment.
I don't see any references to it in any of this diff. Are you sure you are actually using it for your intended purpose?
There was a problem hiding this comment.
That was mentioned in the issue description, jest requires this dependency for inline snapshots: jestjs/jest#8467
There was a problem hiding this comment.
Ah I saw that comment, but I assumed that it would have to be explicitly "used" somewhere.
jakolehm
approved these changes
Nov 25, 2020
jakolehm
added
area/extension
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1461