add no-unused and react/recommended to eslint #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
force-pushed
the
eslint-no-unused
branch
3 times, most recently
from
fb39d4b
to
4c9c3a3
Compare
chenhunghan
requested changes
Nov 26, 2020
There was a problem hiding this comment.
Thanks, this helps improve code readability a lot
Two points, please consider change:
react.versionin.eslintrc.js- There is
if (bundled) {}added insrc/main/kubectl.ts, I am not sure added by mistake or not.
And these extra two, open for discussion I guess:
- Add https://eslint.org/docs/rules/quotes
- About sub rules of
"unused-imports/no-unused-vars-ts", I personally prefer not to use_, as_has many different meanings in different programming language. If a variable is not used, I would suggest just remove it, not adding_, so IMHO these two rules can be removed
"varsIgnorePattern": "^_",
"argsIgnorePattern": "^_",
src/renderer/components/+user-management-roles-bindings/role-binding-details.tsx
Outdated
Show resolved
Hide resolved
src/renderer/item.store.ts
Outdated
| @@ -155,7 +155,7 @@ export abstract class ItemStore<T extends ItemObject = ItemObject> { | |||
|
|
|||
| async removeSelectedItems?(): Promise<any>; | |||
|
|
|||
| subscribe(...args: any[]) { | |||
| subscribe(..._args: any[]) { | |||
There was a problem hiding this comment.
just remove ...args is fine.
There was a problem hiding this comment.
Even if someone wants to overload this function? I think a follow up PR making this an optional function would be better.
panuhorsmalahti
approved these changes
Nov 26, 2020
added quotes: double, and remove ignore pattern Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
eslint-no-unused
branch
from
4c9c3a3
to
4ab4ccf
Compare
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name