Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step to verify docs on area/documentation PRs #1528

Merged
merged 6 commits into from
Nov 27, 2020
Merged

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Nov 25, 2020

Signed-off-by: Sebastian Malton sebastian@malton.name

fixes #1268

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 requested a review from a team November 25, 2020 21:21
@Nokel81 Nokel81 self-assigned this Nov 25, 2020
Copy link
Contributor

@chenhunghan chenhunghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why not just use Github Actions? maybe in the future...

Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaml might not be valid because I don't see any checks (except DCO) here?

.azure-pipelines.yml Outdated Show resolved Hide resolved
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Copy link
Collaborator Author

Nokel81 commented Nov 26, 2020

@jakolehm GH has been set up, and it passes after adding the WIP pages.

@Nokel81 Nokel81 dismissed jakolehm’s stale review November 27, 2020 15:13

Because non-DCO CI checks are now present and listed as passing.

@Nokel81 Nokel81 merged commit 686cb12 into master Nov 27, 2020
@Nokel81 Nokel81 deleted the verify-docs branch November 27, 2020 15:13
@jakolehm jakolehm mentioned this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that docs markdown/config is correct on each PR
3 participants