Add information about the startupProbe #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vshakirova <vshakirova@mirantis.com>
vshakirova
force-pushed
the
add-startup-probe
branch
from
bfdff90
to
eec0bb0
Compare
vshakirova
commented
Nov 26, 2020
| @@ -46,6 +46,26 @@ export class DeploymentApi extends KubeApi<Deployment> { | |||
| } | |||
| } | |||
|
|
|||
| interface IContainerProbe { | |||
There was a problem hiding this comment.
created a new interface in order to remove repeatable code
jakolehm
approved these changes
Dec 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys. I've implemented this feature according to the issue #1034.
just a small comment: StartupProbe should be enabled in your cluster with
--feature-gateflag if your vers < 1.18https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
Please tell me what do you think
Fixes #1034