Disable Uninstall and Enable/Disable buttons while uninstalling #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
panuhorsmalahti
commented
Nov 26, 2020
panuhorsmalahti
commented
- Disable Uninstall and Enable/Disable buttons while uninstalling
- Add "spinner" (e.g. waiting animation) to Uninstall button while install is in progress
- Add Notification for uninstall
panuhorsmalahti
force-pushed
the
feature/uninstall-button-disable
branch
from
8a90e79
to
6b284c1
Compare
jakolehm
added
area/extension
Nokel81
requested changes
Nov 26, 2020
Nokel81
approved these changes
Nov 26, 2020
Comment on lines
51
to
55
| function getRemovedUninstalling(extensions: InstalledExtension[], extensionState: ObservableMap<string, ExtensionState>) { | ||
| return Array.from(extensionState.entries()).filter(([id, extension]) => | ||
| extension.state === "uninstalling" && !extensions.find(extension => extension.id === id) | ||
| ).map(([id, extension]) => ({ ...extension, id })); | ||
| } |
There was a problem hiding this comment.
I think this would be better as a @computed get removedUninstalling() { ... } on the Extensions class bellow.
| description.toLowerCase().includes(searchText), | ||
| ].some(v => v); | ||
| description?.toLowerCase().includes(searchText), | ||
| ].some(value => value); |
There was a problem hiding this comment.
Would using _.filter be more readable?
There was a problem hiding this comment.
Maybe, but not going to touch unrelated code much here, just wanted to fix one char variable naming..
…Notification for uninstall. Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
panuhorsmalahti
force-pushed
the
feature/uninstall-button-disable
branch
from
aba1f71
to
83a8797
Compare
jakolehm
approved these changes
Nov 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.