Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation dialog to extension uninstall #1547

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Add confirmation dialog to extension uninstall #1547

merged 1 commit into from
Nov 27, 2020

Conversation

panuhorsmalahti
Copy link
Contributor

@panuhorsmalahti panuhorsmalahti commented Nov 27, 2020 •
edited

Screenshot 2020-11-27 at 12 46 43

@panuhorsmalahti
Add confirmation dialog to extension uninstall
53f9990 
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
@panuhorsmalahti panuhorsmalahti requested a review from a team November 27, 2020 08:25
chenhunghan
chenhunghan approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@chenhunghan chenhunghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, perhaps attached a screenshot as this is a UI change?

src/renderer/components/+extensions/__tests__/extensions.test.tsx
@@ -2,13 +2,15 @@ import '@testing-library/jest-dom/extend-expect';
import { fireEvent, render, screen } from '@testing-library/react';
import React from 'react';
import { extensionDiscovery } from "../../../../extensions/extension-discovery";
import { ConfirmDialog } from "../../confirm-dialog";
import { Notifications } from "../../notifications";
import { Extensions } from "../extensions";

jest.mock("../../../../extensions/extension-discovery", () => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand grand grand grandma

@panuhorsmalahti panuhorsmalahti merged commit 77c8617 into master Nov 27, 2020
@panuhorsmalahti panuhorsmalahti deleted the feature/confirm-uninstall branch November 27, 2020 10:52
@jakolehm jakolehm mentioned this pull request Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenhunghan chenhunghan chenhunghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panuhorsmalahti @chenhunghan