Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable extension install button while installing #1551

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Disable extension install button while installing #1551

merged 1 commit into from
Nov 27, 2020

Conversation

panuhorsmalahti
Copy link
Contributor

  • Disable Install button and Install input field while installing
  • Fix install notification to be made when the install is actually complete

Screenshot 2020-11-27 at 14 26 49

@panuhorsmalahti
Disable Install button while installing. Fix install notification.
63ecd35 
Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
@panuhorsmalahti panuhorsmalahti requested a review from a team November 27, 2020 12:36
@jakolehm jakolehm added area/extension Something to related to the extension api area/ui labels Nov 27, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Nov 27, 2020
jakolehm
jakolehm approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Much better!

@panuhorsmalahti panuhorsmalahti merged commit b3fd223 into master Nov 27, 2020
@panuhorsmalahti panuhorsmalahti deleted the feature/extension-install-improvements branch November 27, 2020 14:05
@jakolehm jakolehm mentioned this pull request Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
area/extension Something to related to the extension api area/ui
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panuhorsmalahti @jakolehm