Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag cluster & workspace as beta features in extension api #1589

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Dec 1, 2020

Both of those APIs still include internal details that we really have to cleanup. Tagging these as beta will set better expectation level and also allows us to tweak these APIs within 4.x series (until we take the beta tag away).

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added area/extension Something to related to the extension api area/documentation labels Dec 1, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Dec 1, 2020
@jakolehm jakolehm requested a review from a team December 1, 2020 10:33
@jakolehm
Copy link
Contributor Author

jakolehm commented Dec 1, 2020

Cluster cleanup has been already started but it didn't make it into 4.0: #1435

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
src/common/workspace-store.ts Outdated Show resolved Hide resolved
src/common/workspace-store.ts Show resolved Hide resolved
/**
* Cluster
*
* @beta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should probably have some doc describing what we mean by these markers and what guarantees (or not) they mean.

@Nokel81 Nokel81 requested a review from a team December 3, 2020 13:38
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit 8f27559 into master Dec 7, 2020
@jakolehm jakolehm deleted the tag-exposed-extension-stores-as-beta branch December 7, 2020 11:38
jakolehm added a commit that referenced this pull request Dec 7, 2020
* mark cluster & workspace as beta

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>

* back to public

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/extension Something to related to the extension api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants