Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'cannot read property hide of null' error on quit #1594

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Fix 'cannot read property hide of null' error on quit #1594

merged 1 commit into from
Dec 3, 2020

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Dec 1, 2020 •
edited

Fixes error from #1316

@jakolehm
fix 'cannot read property hide of null' error on quit
0e4c3e5 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added the bug Something isn't working label Dec 1, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Dec 1, 2020
@jakolehm jakolehm requested a review from a team December 1, 2020 13:04
nevalla
nevalla approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit ac35bab into master Dec 3, 2020
@jakolehm jakolehm deleted the fix/cannot-read-property-hide-of-null-on-quit branch December 3, 2020 12:55
@jakolehm jakolehm mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

@aleksfront aleksfront aleksfront approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakolehm @nevalla @aleksfront