Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tray icon color on macOS Big Sur #1595

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Conversation

aleksfront
Copy link
Contributor

Using Template Image technique to set tray icon. MacOS automatically changes its color if filename ends with Template.

Windows
windows tray icon

macOS Catalina
catalina tray icon

macOS Big Sur
big sur tray icon

Fixes #1388

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront requested a review from a team December 1, 2020 13:40
Copy link
Collaborator

@Nokel81 Nokel81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though on bigSur it doesn't seem to be changing colours (in your gif)

@aleksfront
Copy link
Contributor Author

Looks good, though on bigSur it doesn't seem to be changing colours (in your gif)

Yep, I suggest all colors will be white regardless of selected theme.

@Nokel81
Copy link
Collaborator

Nokel81 commented Dec 1, 2020

Looks good, though on bigSur it doesn't seem to be changing colours (in your gif)

Yep, I suggest all colors will be white regardless of selected theme.

Why do we want that? That seems like the opposite of how it works on Catalina

@aleksfront
Copy link
Contributor Author

Looks good, though on bigSur it doesn't seem to be changing colours (in your gif)

Yep, I suggest all colors will be white regardless of selected theme.

Why do we want that? That seems like the opposite of how it works on Catalina

This is not our will. Not only our icon always white but all other application's also. That's how Big Sur works since they changed menu line background with semi-transparent color placed over desktop bg image.

@aleksfront aleksfront merged commit 06568fa into master Dec 2, 2020
@aleksfront aleksfront deleted the fix/big-sur-tray-icon branch December 2, 2020 06:54
@jakolehm jakolehm mentioned this pull request Dec 2, 2020
@vshakirova vshakirova mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect tray icon in Light theme macOS Big Sur
2 participants