Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <BottomBar /> support rendering if item is a function #1606

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

chenhunghan
Copy link
Contributor

@chenhunghan chenhunghan commented Dec 2, 2020

This is just an alternative way (another solution #1598) to "fix" issue #1571

Note that it's a duplication of #1598 we should discuss wether or not introduction breaking changes.

Closes #1571

@chenhunghan chenhunghan changed the title Add <Bottom /> support rendering if item is a function Add <BottomBar /> support rendering if item is a function Dec 2, 2020
@chenhunghan chenhunghan marked this pull request as draft December 2, 2020 04:42
@chenhunghan chenhunghan requested a review from a team December 2, 2020 04:44
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
@chenhunghan chenhunghan marked this pull request as ready for review December 2, 2020 09:13
Signed-off-by: Hung-Han (Henry) Chen <1474479+chenhunghan@users.noreply.github.com>
@jakolehm jakolehm added this to the 4.0.0 milestone Dec 2, 2020
@jakolehm jakolehm added area/extension Something to related to the extension api bug Something isn't working labels Dec 2, 2020
@chenhunghan chenhunghan merged commit f6a88b3 into master Dec 2, 2020
@chenhunghan chenhunghan deleted the fix/BottomBar branch December 2, 2020 09:49
@jakolehm jakolehm mentioned this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension Something to related to the extension api bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension API statusBarItems doesn't register status bar items
2 participants