Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine-tuning extensions page view #1613

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Fine-tuning extensions page view #1613

merged 3 commits into from
Dec 3, 2020

Conversation

aleksfront
Copy link
Contributor

  • Removing special html characters from pro-tip message
  • Expanding search box width
  • Getting rid of repeating Name and Description labels

extensions page light
extensions page dark

@aleksfront
Replacing pro-tip text
9910a1c 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Coloring extension name
ea30433 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront requested a review from a team December 2, 2020 10:54
@jakolehm jakolehm added area/ui bug Something isn't working enhancement New feature or request labels Dec 2, 2020
@jakolehm jakolehm added this to the 4.0.0 milestone Dec 2, 2020
@aleksfront
Eslint fixes in webpack files
19d2160 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@Nokel81
Copy link
Collaborator

Nokel81 commented Dec 2, 2020

Should I therefore remove the Version title in #1604 ?

@jakolehm jakolehm merged commit 6630419 into master Dec 3, 2020
@jakolehm jakolehm deleted the fix/extensions-page-typo branch December 3, 2020 06:08
@aleksfront
Copy link
Contributor Author

Should I therefore remove the Version title in #1604 ?

Yes, we can set version as a separate line between extension name and description. Or you can put the version to the right of the name.

@Nokel81
Copy link
Collaborator

Nokel81 commented Dec 3, 2020

I didn't put the version right in the name because it is possible that the name is very long and I didn't want to make it longer.

@jakolehm jakolehm mentioned this pull request Dec 3, 2020
Merged
Torresangl925 added a commit to Torresangl925/lens that referenced this pull request Dec 10, 2020
@Torresangl925
Revert "Fine-tuning extensions page view (lensapp#1613)"
8d963f9 
This reverts commit 6630419.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
area/ui bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleksfront @Nokel81 @jakolehm