Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix URL validator, add some tests #1627

Merged
merged 1 commit into from
Dec 3, 2020
Merged

fix URL validator, add some tests #1627

merged 1 commit into from
Dec 3, 2020

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Dec 2, 2020

Signed-off-by: Sebastian Malton sebastian@malton.name

fixes #1552

@Nokel81
fix URL validator, add some tests
4ef71ac 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added bug Something isn't working area/tests labels Dec 2, 2020
@Nokel81 Nokel81 requested review from panuhorsmalahti and a team December 2, 2020 21:16
@Nokel81 Nokel81 self-assigned this Dec 2, 2020
chenhunghan
chenhunghan approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@chenhunghan chenhunghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe @panuhorsmalahti should take a look

@jakolehm jakolehm added this to the 4.0.0 milestone Dec 3, 2020
@Nokel81 Nokel81 merged commit 4e8fb65 into master Dec 3, 2020
@Nokel81 Nokel81 deleted the issue-1552 branch December 3, 2020 13:49
@jakolehm jakolehm mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenhunghan chenhunghan chenhunghan approved these changes

@panuhorsmalahti panuhorsmalahti panuhorsmalahti approved these changes

Assignees

@Nokel81 Nokel81

Labels
area/tests bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Extension url validator false negative
4 participants
@Nokel81 @chenhunghan @panuhorsmalahti @jakolehm