Fixing SidebarNavItem to rerender when url changes #1638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is happening when user changing namespace - sidebar items gets collapsed:
Changed
url
parameter makes sidebar item to rerender and lose it's expanded/collapsed state.This PR removes search and hash parts from url and passes only pathname to id.
Signed-off-by: Alex Andreev alex.andreev.email@gmail.com