Fixing logs autoscroll behavior #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81
reviewed
Dec 9, 2020
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81
approved these changes
Dec 9, 2020
ixrock
approved these changes
Dec 9, 2020
|
Will you add stop/start function for autoscroll? |
|
@hodolomax Autoscroll function is active when last log line is visible. If scrolled up a bit, this feature will be switched off. |
|
@aleksfront great! thank you |
jakolehm
pushed a commit
that referenced
this pull request
Dec 11, 2020
* Fixing autoscroll behavior Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Making statement simpler to read Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Merged
|
Still broken in 4.0.3 |
|
@Nuru can you provide some more information please? A screenshot of your version information and a gif of the logs screen would be excellent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1709
Signed-off-by: Alex Andreev alex.andreev.email@gmail.com