Clear Add Namespace and Add secret form data on close #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashevskii
force-pushed
the
fix-clear-form-data-on-close
branch
from
1600b63
to
d8cb91a
Compare
pashevskii
changed the title
pashevskii
changed the title
Signed-off-by: Pavel Ashevskii <pashevskii@mirantis.com>
pashevskii
force-pushed
the
fix-clear-form-data-on-close
branch
from
d8cb91a
to
974ab55
Compare
Nokel81
approved these changes
Dec 14, 2020
|
@aleksfront @ixrock PTAL |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit fixes clearing data on closing next forms:
Configuration - Secrets - Add secret
Namespaces - Add Namespace
[Fixed]There is some UI issue: validation of inputs is triggered earlier than form is closed despite that I clear data after isOpen property switching, how can I fix it?[Solution] Reset data before form appearing