Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast update available only after downloading update #2232

Merged
merged 3 commits into from Mar 4, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Feb 25, 2021

Signed-off-by: Sebastian Malton sebastian@malton.name

@Nokel81 Nokel81 added the bug Something isn't working label Feb 25, 2021
@Nokel81 Nokel81 added this to the 4.1.4 milestone Feb 25, 2021
@Nokel81 Nokel81 requested a review from a team February 25, 2021 13:56
@Nokel81 Nokel81 self-assigned this Feb 25, 2021
jim-docker
jim-docker previously approved these changes Feb 25, 2021
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Windows. It does download the update before presenting the notification.

src/main/app-updater.ts Show resolved Hide resolved
@jakolehm jakolehm changed the title broadcast update available only after downloading update Broadcast update available only after downloading update Feb 26, 2021
jakolehm
jakolehm previously approved these changes Feb 26, 2021
@Nokel81
Copy link
Collaborator Author

Nokel81 commented Feb 26, 2021

@jim-docker I think this change might also fix what you were seeing on windows. Now even if the user selects "Install now" the installer is run in silent mode (in the background basically).

@jim-docker
Copy link
Contributor

jim-docker commented Feb 26, 2021

@jim-docker I think this change might also fix what you were seeing on windows. Now even if the user selects "Install now" the installer is run in silent mode (in the background basically).

I'll test it...

Hmm, looks OK:

info: 📡 Checking for app updates
info: Checking for update
info: Found version 4.1.3 (url: Lens-Setup-4.1.3.exe)
info: Downloading update from Lens-Setup-4.1.3.exe
debug: updater cache dir: C:\Users\jiim\AppData\Local\kontena-lens-updater
info: Update has already been downloaded to C:\Users\jiim\AppData\Local\kontena-lens-updater\pending\Lens-Setup-4.1.3.exe).
info: [UPDATE-CHECKER]: broadcasting update available {"backchannel":"auto-update:4.1.3","version":"4.1.3"}
info: [UPDATE-CHECKER]: User chose to update now
info: Install on explicit quitAndInstall
info: Install: isSilent: true, isForceRunAfter: true
info: APP:QUIT
info: [CLUSTER]: disconnect {"id":"dc6b7d54-b790-4549-84dc-ff7a9004d250","initialized":false,"ready":false,"online":false,"accessible":false,"disconnected":true}
info: [CLUSTER]: unbind events {"id":"dc6b7d54-b790-4549-84dc-ff7a9004d250","initialized":false,"ready":false,"online":false,"accessible":false,"disconnected":true}

but same result, nothing installed, nothing run

nevalla
nevalla previously approved these changes Mar 1, 2021
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sebastian Malton <sebastian@malton.name>
…hooses to install update immediately

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 force-pushed the notify-after-download-update branch from b44da31 to fe86ce5 Compare March 1, 2021 15:30
@Nokel81
Copy link
Collaborator Author

Nokel81 commented Mar 1, 2021

@jim-docker Having testing this latest fix on windows, it seems to work.

@jakolehm jakolehm modified the milestones: 4.1.4, 4.1.5 Mar 4, 2021
@Nokel81 Nokel81 merged commit 35e6065 into master Mar 4, 2021
@Nokel81 Nokel81 deleted the notify-after-download-update branch March 4, 2021 13:38
@Nokel81 Nokel81 modified the milestones: 4.1.5, 4.2.0 Mar 5, 2021
This was referenced Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants