New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcast update available only after downloading update #2232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on Windows. It does download the update before presenting the notification.
@jim-docker I think this change might also fix what you were seeing on windows. Now even if the user selects "Install now" the installer is run in silent mode (in the background basically). |
I'll test it... Hmm, looks OK:
but same result, nothing installed, nothing run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sebastian Malton <sebastian@malton.name>
…hooses to install update immediately Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
b44da31
to
fe86ce5
Compare
@jim-docker Having testing this latest fix on windows, it seems to work. |
Signed-off-by: Sebastian Malton sebastian@malton.name