Refactor StorageHelper to be clearer in its constructor #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixrock
reviewed
Mar 31, 2021
|
@Nokel81 Can you please post a brief description why this change needed? There's no link to issue or reference to a bug. |
|
@aleksfront This is trying to fix master where a test is failing on linux. |
|
So after even more debugging I have come to the conclusion that even though I think this is a worth while refactor, the actual solution is to change |
Nokel81
changed the title
|
Changed this PR into a refactor, and opened #2421 to actually fix the bug. |
jim-docker
previously approved these changes
Mar 31, 2021
ixrock
requested changes
Apr 1, 2021
Nokel81
force-pushed
the
initialize-storage-with-default
branch
from
5cc59e6
to
da81ef4
Compare
|
Will look into this thanks. |
ixrock
approved these changes
Apr 3, 2021
- Don't create a box and then override it - Initial value should be the default value Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
initialize-storage-with-default
branch
from
71ad8f6
to
8fafcb4
Compare
Nokel81
added
the
merge/master
jim-docker
approved these changes
Apr 15, 2021
Merged
Nokel81
added a commit
that referenced
this pull request
Apr 16, 2021
Nokel81
removed
the
merge/master
Nokel81
added a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create a box and then override it
Initial value should be the default value
Signed-off-by: Sebastian Malton sebastian@malton.name
@ixrock This is a simpler form of the fix I think.