-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup shell sessions #2469
cleanup shell sessions #2469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you describe where the fix actually is? It's quite hard to spot it now that files were renamed/relocated.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Signed-off-by: Jim Ehrismann jehrismann@mirantis.com
This is targeting a branch since that should be merged before this.
I have tested that this works still with node (remote) shells and local shells.