Improve CatalogEntityRegistry types & add tests #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
jakolehm
added
enhancement
jakolehm
requested review from
a team,
Nokel81 and
aleksfront
and removed request for
a team
aleksfront
approved these changes
Apr 9, 2021
Nokel81
reviewed
Apr 9, 2021
Comment on lines
+22
to
+23
| this.status = data.status as WebLinkStatus; | ||
| this.spec = data.spec as WebLinkSpec; |
There was a problem hiding this comment.
I think we should verify these here instead of just casting them.
nevalla
approved these changes
Apr 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2486