Fix releases not reloading when selecting namespaces #2515
Conversation
- Also changed the tables to show the header even while loading - Fixed small grammer mistake on 0 items (instead of 0 item) Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
added
merge/master
Nokel81
requested review from
a team,
aleksfront and
jim-docker
and removed request for
a team
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
If I don't have access to secrets, Lens correctly reports that it can't list secrets, but the spinner spins forever instead of saying "item list is empty".
|
|
@jim-docker So you think it would be better to say "0 items in list"? How about, "failed to list items"? |
I think most important is that the spinner goes away. "item list is empty" is what is shown when there really are no items. But "failed to list items" would be more precise. Theoretically someone could have RBAC configured so that the user can see some secrets but not all? The releases list might be partial as a result? We could say "failed to list some items"? |
|
@jim-docker I think you can restrict listing of secrets by namespace. So I think your alternative option is best. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
removed
the
merge/master
Signed-off-by: Sebastian Maltonsebastian@malton.name
fixes #2239
As for UI changes, the Header of
ItemListLayoutis not always displayed even while loading. Only the rows of data are conditionally rendered (with a spinner other wise).