Fix how integration tests activate adding a cluster via SpeedDial #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
jim-docker
requested review from
ixrock,
Nokel81 and
jakolehm
and removed request for
a team
|
@jim-docker Is it deprecated in favour of something else? |
Nokel81
approved these changes
Apr 19, 2021
Yes, the actions command, which I've tried to use before to fix other issues. IIRC they aren't supported in the version of Spectron we're stuck on. (I could not get them to work in any case) |
|
Ah okay thanks for the info. So this will be something that we will need to do when we upgrade to the latest version of electron (which is needed for spectron). |
jakolehm
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adding minikube cluster, simulate hover on
SpeedDialto bring up the "Add from kubeconfig"SpeedDialActionBefore this fix, the integration tests run on Ubuntu by CI and locally fail most of the time to add a cluster via the
SpeedDialelement.This fix involves using spectron client's
moveToObject()method (which appears to rely on themoveTo()method, which is deprecated).tries to fix #2564