Bump url-parse from 1.4.7 to 1.5.1 #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.1. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.4.7...1.5.1) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
nevalla and
jim-docker
and removed request for
a team
dependabot
bot
added
the
dependencies
jim-docker
previously approved these changes
May 10, 2021
|
@Nokel81 ptal (protocol handler tests are failing). |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
reviewed
May 11, 2021
| try { | ||
| expect(await lpr.route("lens://extension/@mirantis/minikube")).toBeUndefined(); | ||
| } catch (error) { | ||
| expect(throwIfDefined(error)).not.toThrow(); | ||
| } | ||
|
|
||
| expect(broadcastMessage).toHaveBeenNthCalledWith(1, ProtocolHandlerInternal, "lens://app"); | ||
| expect(broadcastMessage).toHaveBeenNthCalledWith(1, ProtocolHandlerInternal, "lens://app/"); |
There was a problem hiding this comment.
I think this was changed in 1.5.0 as a result of a security patch. It shouldn't matter to us because we just parse it again on the other side.
Nokel81
approved these changes
May 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps url-parse from 1.4.7 to 1.5.1.
Commits
eb6d9f5[dist] 1.5.1750d8e8[fix] Fixes relative path resolving #199 #200 (#201)3ac7774[test] Make test consistent for browser testing267a0c6[dist] 1.5.0d1e7e88[security] More backslash fixes (#197)d99bf4c[ignore] Remove npm-debug.log from .gitignore422c8b5[pkg] Replace nyc with c8933809d[pkg] Move coveralls to dev dependencies190b216[pkg] Add .npmrcce3783f[test] Do not test on all available versions of Edge and SafariDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)