Make DetectoryRegistry a Singleton and initialize in a function #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
force-pushed
the
detector-registry-singleton
branch
from
3cb7cde
to
2515010
Compare
Nokel81
force-pushed
the
split-kubeobject-components
branch
from
ab2df32
to
2394b67
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
detector-registry-singleton
branch
from
2515010
to
3a3ff91
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nokel81
force-pushed
the
split-kubeobject-components
branch
from
2394b67
to
e6bc229
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
detector-registry-singleton
branch
from
3a3ff91
to
ec924bc
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nokel81
requested review from
nevalla,
aleksfront and
jim-docker
and removed request for
a team
jim-docker
reviewed
Aug 3, 2021
Signed-off-by: Sebastian Malton <sebastian@malton.name>
jim-docker
approved these changes
Aug 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
part of splitting out ban-cir-deps