Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lookupApi into apiManager #3540

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Move lookupApi into apiManager #3540

merged 2 commits into from
Aug 4, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Jul 30, 2021

  • Don't export kube-api-parse from kube-api (cir-deps)

Signed-off-by: Sebastian Malton sebastian@malton.name

part of splitting apart ban-cir-deps

@Nokel81 Nokel81 added the chore label Jul 30, 2021
@Nokel81 Nokel81 added this to the 5.2.0 milestone Jul 30, 2021
@Nokel81 Nokel81 self-assigned this Jul 30, 2021
@Nokel81 Nokel81 mentioned this pull request Jul 30, 2021
9 tasks
@Nokel81 Nokel81 removed their assignment Aug 3, 2021
@Nokel81 Nokel81 force-pushed the detector-registry-singleton branch from 2515010 to 3a3ff91 Compare August 3, 2021 14:51
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Nokel81 Nokel81 force-pushed the detector-registry-singleton branch from 3a3ff91 to ec924bc Compare August 3, 2021 21:42
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Base automatically changed from detector-registry-singleton to master August 4, 2021 12:48
- Don't export kube-api-parse from kube-api (cir-deps)

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 marked this pull request as ready for review August 4, 2021 12:49
@Nokel81 Nokel81 requested a review from a team as a code owner August 4, 2021 12:49
@Nokel81 Nokel81 requested review from jakolehm and Nachasic and removed request for a team August 4, 2021 12:49
@Nokel81 Nokel81 assigned Nokel81 and unassigned Nokel81 Aug 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@jim-docker
Copy link
Contributor

Not sure if this is related to something in this chain of PRs:

definitionShowsDetails.mov

Clicking on a definition sometimes brings up the details page, when it should bring up the list of CRD instances?

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Aug 4, 2021

@jim-docker Do you mean that it is strange that the drawer opens when you click the row near the name of the CRD but opens the list of resources if you click the name?

I think that has always been the situation.

@jim-docker
Copy link
Contributor

@jim-docker Do you mean that it is strange that the drawer opens when you click the row near the name of the CRD but opens the list of resources if you click the name?

I think that has always been the situation.

Ah, I see, I was clicking just below the word "Prometheus", such that it wasn't highlighted (wasn't white instead of blue), hence the details came up

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Aug 4, 2021

Yes I agree, that it is a bit of a bad design and should probably open the list of resources when clicking that entire cell (and not just the text), but that is for a different PR.

@Nokel81 Nokel81 merged commit ee158e3 into master Aug 4, 2021
@Nokel81 Nokel81 deleted the apimanger-lookupapi branch August 4, 2021 15:36
@Nokel81 Nokel81 mentioned this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants