Remove directly depending on openid-client #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
requested review from
nevalla and
aleksfront
and removed request for
a team
Nokel81
force-pushed
the
remove-openid-client
branch
from
713d8ba
to
823bd65
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Add got as a direct dep as we are already using it Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
remove-openid-client
branch
from
823bd65
to
6d704f9
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jakolehm
previously requested changes
Oct 8, 2021
| @@ -202,6 +202,7 @@ | |||
| "filehound": "^1.17.4", | |||
| "fs-extra": "^9.0.1", | |||
| "glob-to-regexp": "^0.4.1", | |||
| "got": "^11.8.2", | |||
There was a problem hiding this comment.
Please remove from this PR.
There was a problem hiding this comment.
Was not obvious that we already had this as a dependency.
jakolehm
dismissed
their stale review
Was not obvious that we already had this as a dependency.
jakolehm
approved these changes
Oct 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
closes #3932
We don't use this directly in our code so we shouldn't pull it in as a dep