Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in HotbarStore migrations #4105

Merged
merged 1 commit into from Oct 22, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Oct 21, 2021

  • When the store's migration version was in between some of the
    migrations but didn't have any hotbars defined

  • Add some more checks on the types of hotbars

Signed-off-by: Sebastian Malton sebastian@malton.name

- When the store's migration version was in between some of the
  migrations but didn't have any hotbars defined

- Add some more checks on the types of hotbars

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the bug Something isn't working label Oct 21, 2021
@Nokel81 Nokel81 requested a review from a team as a code owner October 21, 2021 13:28
@Nokel81 Nokel81 requested review from nevalla, aleksfront and jim-docker and removed request for a team October 21, 2021 13:28
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit cd14097 into master Oct 22, 2021
@Nokel81 Nokel81 deleted the fix-hotbar-5.0.0-beta.10-migration branch October 22, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants