Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle named ports in probe label renderer #4118

Merged
merged 1 commit into from Oct 25, 2021
Merged

Handle named ports in probe label renderer #4118

merged 1 commit into from Oct 25, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Oct 22, 2021

Signed-off-by: Sebastian Malton sebastian@malton.name

fixes #668

@Nokel81
Handle named ports in probe label renderer
5b4f4bc 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the bug Something isn't working label Oct 22, 2021
@Nokel81 Nokel81 requested a review from a team as a code owner October 22, 2021 13:15
@Nokel81 Nokel81 requested review from nevalla and jakolehm and removed request for a team October 22, 2021 13:15
nevalla
nevalla approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit 221ab46 into master Oct 25, 2021
@Nokel81 Nokel81 deleted the issue-668 branch October 25, 2021 14:40
@jim-docker jim-docker mentioned this pull request Oct 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

@jakolehm jakolehm Awaiting requested review from jakolehm jakolehm is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I'm seeing liveness and readiness probe report as "http://:http/$HEALTH_CHECK_ENDPOINT"
2 participants
@Nokel81 @nevalla