Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support port forwarding https protocol #4119

Merged
merged 7 commits into from Oct 25, 2021
Merged

Conversation

jim-docker
Copy link
Contributor

fixes #3641

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
…ort-forward address to the details page title

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
@jim-docker jim-docker requested a review from a team as a code owner October 22, 2021 17:25
@jim-docker jim-docker requested review from Nokel81 and aleksfront and removed request for a team October 22, 2021 17:25
@jim-docker jim-docker added the enhancement New feature or request label Oct 22, 2021
@jim-docker jim-docker changed the title Feature/port forward https Support port forwarding https protocol Oct 22, 2021
@jim-docker jim-docker added this to the 5.3.0 milestone Oct 22, 2021
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

jim-docker and others added 2 commits October 22, 2021 17:38
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
@jim-docker jim-docker merged commit 353b79a into master Oct 25, 2021
@jim-docker jim-docker deleted the feature/port-forward-https branch October 25, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port-forward should use https if port name is https
2 participants