Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize window on topbar double click #4379

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

aleksfront
Copy link
Contributor

Maximize/minimize window after clicking topbar area. Preserving common behavior across other apps.

maximize.window.mov

Resolves #4257

Signed-off-by: Alex Andreev alex.andreev.email@gmail.com

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront added enhancement New feature or request area/ui labels Nov 18, 2021
@aleksfront aleksfront added this to the 5.3.0 milestone Nov 18, 2021
@aleksfront aleksfront requested a review from a team as a code owner November 18, 2021 12:46
Copy link
Contributor

@jweak jweak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit 8bc9368 into master Nov 18, 2021
@Nokel81 Nokel81 deleted the maximize-window-on-topbar-doubleclick branch November 18, 2021 14:08
@Nokel81
Copy link
Collaborator

Nokel81 commented Nov 18, 2021

I wonder why this didn't conflict with the drag area... That is what I ran into when I tried.

@jer0m
Copy link

jer0m commented Nov 18, 2021

Awesome thanks!

@aleksfront
Copy link
Contributor Author

I wonder why this didn't conflict with the drag area... That is what I ran into when I tried.

The drag area has pointer-events: none which allows all clicks go through it. So it's like an invisible for mouse events, but still "visible" for dragging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App resize on MacOS
4 participants