-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer usage of preference over autoselection #4436
Merged
Nokel81
merged 1 commit into
lensapp:master
from
farodin91:prefer-usage-of-preference-over-autoselection
Nov 30, 2021
Merged
Prefer usage of preference over autoselection #4436
Nokel81
merged 1 commit into
lensapp:master
from
farodin91:prefer-usage-of-preference-over-autoselection
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
reviewed
Nov 26, 2021
Nokel81
reviewed
Nov 29, 2021
Nokel81
reviewed
Nov 29, 2021
Nokel81
previously approved these changes
Nov 30, 2021
@farodin91 Please sign all commits in this PR (or just squash and sign that one) |
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
dbb21e8
to
0556fcf
Compare
@Nokel81 done |
Nokel81
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metrics
All the things related to metrics
area/rbac
Something related to Kube RBAC permissions
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Lens 5.3, I didn't need to able to query all service in Kubernetes.
Signed-off-by: Jan Jansen jan.jansen@gdata.de