add debug for locating startup issues #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
jim-docker
requested review from
nevalla and
jakolehm
and removed request for
a team
aleksfront
reviewed
Dec 2, 2021
src/main/index.ts
Outdated
| @@ -99,6 +101,8 @@ if (app.commandLine.getSwitchValue("proxy-server") !== "") { | |||
| process.env.HTTPS_PROXY = app.commandLine.getSwitchValue("proxy-server"); | |||
| } | |||
|
|
|||
| logger.debug("lprm stuff"); | |||
There was a problem hiding this comment.
Maybe change to more descriptive message? Not quite sure what is lprm within context.
There was a problem hiding this comment.
sure, this was meant to be temporary but maybe this logging should stay. I'll add a log prefix as well
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Nokel81
approved these changes
Dec 2, 2021
Nokel81
pushed a commit
that referenced
this pull request
Dec 9, 2021
Closed
Nokel81
pushed a commit
that referenced
this pull request
Dec 9, 2021
Nokel81
pushed a commit
that referenced
this pull request
Dec 9, 2021
Merged
Nokel81
pushed a commit
that referenced
this pull request
Dec 10, 2021
Nokel81
pushed a commit
that referenced
this pull request
Dec 13, 2021
Nokel81
pushed a commit
that referenced
this pull request
Dec 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Ehrismann jehrismann@mirantis.com
For help diagnosing the problem in #4473