Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ERR_UNSAFE_PORT from LensProxy #4558

Merged
merged 3 commits into from Dec 14, 2021
Merged

Fix ERR_UNSAFE_PORT from LensProxy #4558

merged 3 commits into from Dec 14, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Dec 10, 2021

  • Use the current list of ports from chromium as it is much easier to
    just reject using one of those instead of trying to handle the
    ERR_UNSAFE_PORT laod error from a BrowserWindow.on("did-fail-load")

Signed-off-by: Sebastian Malton sebastian@malton.name

@Nokel81
Fix ERR_UNSAFE_PORT from LensProxy
6c9a53f 
- Use the current list of ports from chromium as it is much easier to
  just reject using one of those instead of trying to handle the
  ERR_UNSAFE_PORT laod error from a BrowserWindow.on("did-fail-load")

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the bug Something isn't working label Dec 10, 2021
@Nokel81 Nokel81 requested a review from a team as a code owner December 10, 2021 20:38
@Nokel81 Nokel81 requested review from jweak and jakolehm and removed request for a team December 10, 2021 20:38
@Nokel81
Copy link
Collaborator Author

Nokel81 commented Dec 10, 2021

This can be tested by using the following generator to attempt to use the bad ports:

const portNumbers = (function*() {
  yield 1719;
  yield 1720;
  yield 1723;
  yield 2049;
  yield 3659;
  yield 4045;
  yield 5060;
  yield 5061;
  yield 6000;
  yield 6566;
  yield 6665;
  yield 6666;
  yield 6667;
  yield 6668;
  yield 6669;
  yield 6697;
  yield 10080;

  for (;;) {
    yield 0;
  }
})();

@Nokel81 Nokel81 linked an issue Dec 10, 2021 that may be closed by this pull request
ERR_UNSAFE_PORT (-312) loading 'http://localhost:4045/' #4524
Closed
@Nokel81 Nokel81 added this to the 5.3.4 milestone Dec 10, 2021
jakolehm
jakolehm reviewed Dec 11, 2021
View reviewed changes
src/main/index.ts Outdated Show resolved Hide resolved
@Nokel81
Move all port handling into LensProxy
40fa387 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
don't use so many exceptions
29e675b 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
jakolehm
jakolehm approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jweak
jweak approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jweak jweak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit 56e72b3 into master Dec 14, 2021
@jakolehm jakolehm deleted the issue-4524 branch December 14, 2021 10:38
jim-docker pushed a commit that referenced this pull request Jan 19, 2022
@Nokel81 @jim-docker
Fix ERR_UNSAFE_PORT from LensProxy (#4558)
0137a4d 
* Fix ERR_UNSAFE_PORT from LensProxy

- Use the current list of ports from chromium as it is much easier to
  just reject using one of those instead of trying to handle the
  ERR_UNSAFE_PORT laod error from a BrowserWindow.on("did-fail-load")

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Move all port handling into LensProxy

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* don't use so many exceptions

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@jim-docker jim-docker mentioned this pull request Jan 19, 2022
Merged
jim-docker pushed a commit that referenced this pull request Jan 19, 2022
@Nokel81 @jim-docker
Fix ERR_UNSAFE_PORT from LensProxy (#4558)
c2f42af 
* Fix ERR_UNSAFE_PORT from LensProxy

- Use the current list of ports from chromium as it is much easier to
  just reject using one of those instead of trying to handle the
  ERR_UNSAFE_PORT laod error from a BrowserWindow.on("did-fail-load")

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Move all port handling into LensProxy

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* don't use so many exceptions

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
jim-docker added a commit that referenced this pull request Jan 20, 2022
@jim-docker @Nokel81
@jakolehm @aleksfront @nevalla
Release/v5.3.4 (#4721)
e8d8f8f 
* Use electron.clipboard for all clipboard uses (#4535)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix ERR_UNSAFE_PORT from LensProxy (#4558)

* Fix ERR_UNSAFE_PORT from LensProxy

- Use the current list of ports from chromium as it is much easier to
  just reject using one of those instead of trying to handle the
  ERR_UNSAFE_PORT laod error from a BrowserWindow.on("did-fail-load")

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Move all port handling into LensProxy

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* don't use so many exceptions

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix not being able to clear set cluster icon (#4555)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix extension engine range not working for some ^ ranges (#4554)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix crash on NetworkPolicy when matchLabels is missing (#4500)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Replace all uses of promiseExec with promiseExecFile (#4514)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Less noisy metrics-not-available error logging (#4602)

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix close button overflow in Preferences (#4611)

* Adding basic colors to tailwind theme

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Using tailwind inline to style close button

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Make Select look similar to inputs

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Moving styles into separate module

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Convert tailwind commands to css

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix prometheus operator metrics work out of the box (#4617)

Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix CRD.getPreferedVersion() to work based on apiVersion (#4553)

* Fix CRD.getPreferedVersion() to work based on apiVersion

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Fix crash for KubeObjectStore.loadAll() (#4675)

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Convert CloseButton styles out from css modules (#4723)

* Convert CloseButton styles out from css modules

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Fix close button styling

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* release v5.3.4

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

Co-authored-by: Sebastian Malton <sebastian@malton.name>
Co-authored-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>
Co-authored-by: Lauri Nevala <lauri.nevala@gmail.com>
@jim-docker jim-docker mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jweak jweak jweak approved these changes

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.3.4
Development

Successfully merging this pull request may close these issues.

ERR_UNSAFE_PORT (-312) loading 'http://localhost:4045/'
3 participants
@Nokel81 @jweak @jakolehm