Upgrade to Electron 14.2.4 #4625

jakolehm · 2022-01-03T14:21:33Z

updates Electron to 14.2.1 (https://www.electronjs.org/releases/stable?version=14)
removes @electron/remote dependency:

Warning! This module has many subtle pitfalls. There is almost always a better way to accomplish your task than using this module. For example, ipcRenderer.invoke can serve many common use cases.

ixrock

LGTM

ixrock · 2022-01-04T10:37:18Z

src/common/ipc/ipc.ts

+
+    // There will be a uncaught exception if the view is destroyed.
+    try {
+      viewType = view.getType();


Maybe better to check view.isDestroyed() instead of try-catch or it might catch something else?

Didn't change this logic, not sure if I want to change it in this PR 😅

src/renderer/components/layout/top-bar/top-bar.tsx

src/common/ipc/ipc.ts

.yarnrc

github-actions · 2022-01-05T14:37:33Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2022-01-09T16:11:00Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

Nokel81 · 2022-01-10T14:33:26Z

@jakolehm Please fix lint and then I say this is RTM!

jakolehm · 2022-01-10T14:39:43Z

@jakolehm Please fix lint and then I say this is RTM!

Fixed!

github-actions · 2022-01-10T15:51:23Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2022-01-10T16:13:43Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2022-01-17T18:57:31Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Sebastian Malton <sebastian@malton.name>

github-actions · 2022-01-24T17:38:55Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

Signed-off-by: Sebastian Malton <sebastian@malton.name>

jim-docker · 2022-01-25T22:47:59Z

On linux and windows, after the first time opening the app menus, it takes two clicks to open them:

Screen.Recording.2022-01-25.at.5.43.25.PM.mov

works fine on master

@Nokel81 This was introduced by the last two commits (bb905bc and 18ec143)

jim-docker · 2022-01-26T00:10:29Z

windows integration tests fail intermittently, seems to be due to an issue in playwright (something that hasn't been updated for Electron 14). Tried downgrading playwright to 1.15.2 and upgrading to 1.18.1, with same results. May be the same issue as recently reported here

I have not found a workaround yet.

Signed-off-by: Sebastian Malton <sebastian@malton.name>

…e with Electron 14 on windows Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

jakolehm added the enhancement New feature or request label Jan 3, 2022

jakolehm added this to the 5.4.0 milestone Jan 3, 2022

ixrock previously approved these changes Jan 4, 2022

View reviewed changes

Nokel81 reviewed Jan 4, 2022

View reviewed changes

src/common/ipc/ipc.ts Outdated Show resolved Hide resolved

jakolehm dismissed ixrock’s stale review via 41e3e92 January 4, 2022 16:42

jakolehm marked this pull request as ready for review January 4, 2022 17:03

jakolehm requested a review from a team as a code owner January 4, 2022 17:03

jakolehm requested review from Iku-turso, Nokel81 and a team and removed request for a team January 4, 2022 17:03

Nokel81 reviewed Jan 4, 2022

View reviewed changes

.yarnrc Outdated Show resolved Hide resolved

Nokel81 previously approved these changes Jan 5, 2022

View reviewed changes

github-actions bot added the PR: needs rebase label Jan 5, 2022

Nokel81 mentioned this pull request Jan 5, 2022

Ban circular dependencies #3547

Merged

9 tasks

jakolehm dismissed Nokel81’s stale review via 8311943 January 9, 2022 16:10

github-actions bot removed the PR: needs rebase label Jan 9, 2022

Nokel81 previously approved these changes Jan 10, 2022

View reviewed changes

Nokel81 requested a review from ixrock January 10, 2022 14:39

github-actions bot added the PR: needs rebase label Jan 10, 2022

github-actions bot removed the PR: needs rebase label Jan 10, 2022

ixrock previously approved these changes Jan 10, 2022

View reviewed changes

github-actions bot added the PR: needs rebase label Jan 17, 2022

Fix build and tests

9fa7519

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Nokel81 dismissed stale reviews from ixrock and themself via 9fa7519 January 24, 2022 17:38

Nokel81 force-pushed the electron-14 branch from a976848 to 9fa7519 Compare January 24, 2022 17:38

Nokel81 changed the title ~~Electron 14.2.1~~ Upgrade to Electron 14.2.4 Jan 24, 2022

github-actions bot removed the PR: needs rebase label Jan 24, 2022

Nokel81 added 4 commits January 24, 2022 12:39

revert extensions

f40f9fc

Signed-off-by: Sebastian Malton <sebastian@malton.name>

revert version

0e69d26

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Split out more ipc channels

36cb5aa

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Fix test

2665cfc

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Nokel81 previously approved these changes Jan 24, 2022

View reviewed changes

Toggle app context menu on windows and linux

bb905bc

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Nokel81 dismissed their stale review via bb905bc January 24, 2022 20:11

Fix topbar

18ec143

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Nokel81 and others added 2 commits January 26, 2022 14:45

Revert top bar changes, switch to nativeWindowOpen=true

5387b20

Signed-off-by: Sebastian Malton <sebastian@malton.name>

added integration test bulletproofing to workaround a playwright issu…

f89ffb6

…e with Electron 14 on windows Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

Nokel81 previously approved these changes Jan 26, 2022

View reviewed changes

skip preferences integration test on windows due to playwright issue

4c1ee54

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

jim-docker dismissed Nokel81’s stale review via 4c1ee54 January 26, 2022 22:11

Nokel81 previously approved these changes Jan 26, 2022

View reviewed changes

skip command palette integration test on windows due to playwright issue

fd1f415

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

jim-docker dismissed Nokel81’s stale review via fd1f415 January 27, 2022 01:42

Nokel81 approved these changes Jan 27, 2022

View reviewed changes

jim-docker approved these changes Jan 27, 2022

View reviewed changes

Nokel81 merged commit 1cac3ca into master Jan 27, 2022

Nokel81 deleted the electron-14 branch January 27, 2022 15:23

jim-docker mentioned this pull request Jan 31, 2022

release v5.4.0-alpha.0 #4780

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Electron 14.2.4 #4625

Upgrade to Electron 14.2.4 #4625

jakolehm commented Jan 3, 2022 •

edited

ixrock left a comment

ixrock Jan 4, 2022

jakolehm Jan 4, 2022

github-actions bot commented Jan 5, 2022

github-actions bot commented Jan 9, 2022

Nokel81 commented Jan 10, 2022

jakolehm commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

github-actions bot commented Jan 17, 2022

github-actions bot commented Jan 24, 2022

jim-docker commented Jan 25, 2022 •

edited

jim-docker commented Jan 26, 2022

Upgrade to Electron 14.2.4 #4625

Upgrade to Electron 14.2.4 #4625

Conversation

jakolehm commented Jan 3, 2022 • edited

ixrock left a comment

Choose a reason for hiding this comment

ixrock Jan 4, 2022

Choose a reason for hiding this comment

jakolehm Jan 4, 2022

Choose a reason for hiding this comment

github-actions bot commented Jan 5, 2022

github-actions bot commented Jan 9, 2022

Nokel81 commented Jan 10, 2022

jakolehm commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

github-actions bot commented Jan 17, 2022

github-actions bot commented Jan 24, 2022

jim-docker commented Jan 25, 2022 • edited

jim-docker commented Jan 26, 2022

jakolehm commented Jan 3, 2022 •

edited

jim-docker commented Jan 25, 2022 •

edited