fix parseApi to not throw and to match apiVersion more specifically #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Nokel81
force-pushed
the
remove-parseApi-throw
branch
from
bcad7cd
to
1107ff3
Compare
Nokel81
changed the title
- Add many more unit tests (these are exact copies of the old behaviour so that any changes do not change behaviour) - Make explicit, with documentation, why certain actions are being taken with the parsing of the api URL parts Signed-off-by: Sebastian Malton <smalton@mirantis.com>
|
@nevalla @jakolehm This PR should be the last one (I am so sorry it took so many attempts). I have spent extra time verifying that nothing else is broken (especially side bars) and have added many more unit tests to make sure that any changes I need to make don't change behaviour on the previously working strings. I guess this goes to show how much testing can be beneficial. |
jakolehm
approved these changes
Jun 22, 2020
nevalla
reviewed
Jun 22, 2020
Signed-off-by: Sebastian Malton <smalton@mirantis.com>
Nokel81
force-pushed
the
remove-parseApi-throw
branch
from
454e31a
to
e20d2f3
Compare
|
@Nokel81 this PR seems to break namespace details. |
ixrock
reviewed
Jun 22, 2020
| [apiGroup, apiVersion, resource] = left; | ||
| switch (left.length) { | ||
| case 2: | ||
| resource = left.pop(); |
There was a problem hiding this comment.
I meant to leave that out, but I will add some more tests once I find which is wrong...
nevalla
pushed a commit
that referenced
this pull request
Jun 24, 2020
…496) * remove the explicit throw is new parseApi * fix parseApi to be more consitent with the older version - Add many more unit tests (these are exact copies of the old behaviour so that any changes do not change behaviour) - Make explicit, with documentation, why certain actions are being taken with the parsing of the api URL parts Signed-off-by: Sebastian Malton <smalton@mirantis.com> Co-authored-by: Sebastian Malton <smalton@mirantis.com>
This was referenced Jun 24, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton smalton@mirantis.com
This PR removes the explicit throw in
parseApi. That function is assumed by several parts of the code to be "no-throw" and to return an empty (ish) object if the passed in URL is not an API URL.Add a unit test to cover this case.